fix(security): harden keychain iframe loading and keychain CSP #2384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Security Impact
javascript:,data:, remotehttp:).local-network-accessnow localhost-only).Testing
pnpm lint:checkpnpm --filter @cartridge/controller test -- iframeSecuritypnpm --filter @cartridge/controller test(fails on existing unrelated parseChainId.test.ts invalid URL case)pnpm --filter @cartridge/keychain build(currently fails due pre-existing type export mismatches in keychain)Self-Review
http://localhost,127.0.0.1,::1).